This forum is for discussion related to the game.
Flubbernugget
Flubbernugget
Survivor
Flubbernugget
Survivor Survivor
Posts: 11751 Joined: June 26, 2014
Post
Post #125 (ISO ) » Tue May 15, 2018 2:19 pm
Post
by Flubbernugget » Tue May 15, 2018 2:19 pm
The push is going to come in with my one line change to donbot.
Flubbernugget
Flubbernugget
Survivor
Flubbernugget
Survivor Survivor
Posts: 11751 Joined: June 26, 2014
Post
Post #126 (ISO ) » Tue May 15, 2018 2:20 pm
Post
by Flubbernugget » Tue May 15, 2018 2:20 pm
also maybe dos2unix format issues
Flubbernugget
Flubbernugget
Survivor
Flubbernugget
Survivor Survivor
Posts: 11751 Joined: June 26, 2014
Post
Post #127 (ISO ) » Tue May 15, 2018 2:24 pm
Post
by Flubbernugget » Tue May 15, 2018 2:24 pm
Push is on my fork under the branch "prodbot"
Flubbernugget
Flubbernugget
Survivor
Flubbernugget
Survivor Survivor
Posts: 11751 Joined: June 26, 2014
Post
Post #128 (ISO ) » Tue May 15, 2018 2:30 pm
Post
by Flubbernugget » Tue May 15, 2018 2:30 pm
In post 123 , GreenLiquid wrote: Right, sorry, I meant... is it possible to get it out of its state of not sending PMs by exiting and re-launching the application? Just to see if it's something within that session or not. Might help narrow down the cause.
I don't have much more time tonight to continue working on this, but I am willing to give this a shot at a later date.
So something like this?
Code: Select all
-> Send pm to 13 users. Fail!
-> Send pm to 13 users. Press CTRL+C. Program terminates.
-> Send pm to 13 users. Pass!
GreenLiquid
GreenLiquid
Mafia Scum
GreenLiquid
Mafia Scum Mafia Scum
Posts: 1054 Joined: July 15, 2005
Post
Post #129 (ISO ) » Tue May 15, 2018 2:51 pm
Post
by GreenLiquid » Tue May 15, 2018 2:51 pm
Yeah, something like that. But Psyche might have an insight to allow us to avoid a trial-and-error approach altogether.
Avatar courtesy of Chickadee! |
GTKAL
northsidegal
northsidegal
Survivor
northsidegal
Survivor Survivor
Posts: 11587 Joined: August 23, 2017
Post
Post #130 (ISO ) » Tue May 15, 2018 7:24 pm
Post
by northsidegal » Tue May 15, 2018 7:24 pm
It seems that trying to input a value greater than 60 for the pagetopping tool gave me a "ValueError: invalid literal for int() with base 10: '' error.
It also seems that sometimes the counter goes into negative numbers instead of resetting when hitting zero.
Psyche
Psyche he/they
Survivor
Psyche he/they
Survivor Survivor
Posts: 10762 Joined: April 28, 2011
Pronoun: he/they
Post
Post #131 (ISO ) » Tue May 15, 2018 7:49 pm
Post
by Psyche » Tue May 15, 2018 7:49 pm
hm ok
yessiree
yessiree he
Mafia Scum
yessiree he
Mafia Scum Mafia Scum
Posts: 4389 Joined: June 6, 2013
Pronoun: he
Post
Post #132 (ISO ) » Wed May 16, 2018 4:36 am
Post
by yessiree » Wed May 16, 2018 4:36 am
I think I know what this is.
1. The input field that you're storing the counter has type=text, it should be type=number
2.
JavaScript has problems representing floating point numbers
3. Shit hits the fan when you're trying to multiply it by 1 in the setInterval() function
suggestion (optional): since I don't think people will be staring at the pagetopper page constantly, instead of setInterval(), use setTimeout() and use the counter as the timeout should probably be cleaner
Edit: probably should not be converting string into numbers by multiplying it with 1, use parseInt() instead
Flubbernugget
Flubbernugget
Survivor
Flubbernugget
Survivor Survivor
Posts: 11751 Joined: June 26, 2014
Post
Post #133 (ISO ) » Wed May 16, 2018 4:52 am
Post
by Flubbernugget » Wed May 16, 2018 4:52 am
Fuckin Javascript lol
On a side note, would anyone be opposed to me importing a bootstrap template for the personal Modbot ui?
Psyche
Psyche he/they
Survivor
Psyche he/they
Survivor Survivor
Posts: 10762 Joined: April 28, 2011
Pronoun: he/they
Post
Post #134 (ISO ) » Wed May 16, 2018 4:56 am
Post
by Psyche » Wed May 16, 2018 4:56 am
what's that
Flubbernugget
Flubbernugget
Survivor
Flubbernugget
Survivor Survivor
Posts: 11751 Joined: June 26, 2014
Post
Post #135 (ISO ) » Wed May 16, 2018 4:58 am
Post
by Flubbernugget » Wed May 16, 2018 4:58 am
It's a set of CSS templates to make a website look pretty in a short period of time. I think it's written by Twitter people
yessiree
yessiree he
Mafia Scum
yessiree he
Mafia Scum Mafia Scum
Posts: 4389 Joined: June 6, 2013
Pronoun: he
Post
Post #136 (ISO ) » Wed May 16, 2018 5:59 am
Post
by yessiree » Wed May 16, 2018 5:59 am
I have some different ideas about how to go about implementing the pagetopper. Im just gonna build the backend for it in a separate class
Psyche
Psyche he/they
Survivor
Psyche he/they
Survivor Survivor
Posts: 10762 Joined: April 28, 2011
Pronoun: he/they
Post
Post #137 (ISO ) » Wed May 16, 2018 10:01 am
Post
by Psyche » Wed May 16, 2018 10:01 am
yeah totally fine
Psyche
Psyche he/they
Survivor
Psyche he/they
Survivor Survivor
Posts: 10762 Joined: April 28, 2011
Pronoun: he/they
Post
Post #138 (ISO ) » Wed May 16, 2018 10:01 am
Post
by Psyche » Wed May 16, 2018 10:01 am
i will be distracted from this project till the weekend
yessiree
yessiree he
Mafia Scum
yessiree he
Mafia Scum Mafia Scum
Posts: 4389 Joined: June 6, 2013
Pronoun: he
Post
Post #139 (ISO ) » Thu May 17, 2018 7:38 am
Post
by yessiree » Thu May 17, 2018 7:38 am
In post 64 , Psyche wrote: me and radiantcowbells found a bug in getNumberOfPosts() that makes it fail when there are unread posts in the thread. disgusting.
im guessing this is never fixed
Psyche
Psyche he/they
Survivor
Psyche he/they
Survivor Survivor
Posts: 10762 Joined: April 28, 2011
Pronoun: he/they
Post
Post #140 (ISO ) » Thu May 17, 2018 8:56 am
Post
by Psyche » Thu May 17, 2018 8:56 am
No it’s fixed
yessiree
yessiree he
Mafia Scum
yessiree he
Mafia Scum Mafia Scum
Posts: 4389 Joined: June 6, 2013
Pronoun: he
Post
Post #141 (ISO ) » Thu May 17, 2018 9:03 am
Post
by yessiree » Thu May 17, 2018 9:03 am
ok so, I fix the bug mentioned above, because that's needed for the pagetopper to work
also finished a prototype for the pagetopper. It takes care of the scheduling part in python, so effectively eliminating the need to do it on the client side /w JavaScript.
to run it, you need to initialize it with a thread, and the current page number of the thread, then call the run() function
I'm currently testing in a game im modding so we'll see how that goes lol
pedit: are you sure?
yessiree
yessiree he
Mafia Scum
yessiree he
Mafia Scum Mafia Scum
Posts: 4389 Joined: June 6, 2013
Pronoun: he
Post
Post #142 (ISO ) » Thu May 17, 2018 9:06 am
Post
by yessiree » Thu May 17, 2018 9:06 am
I'm pretty sure the current code will fail if you try to get the post number of a thread that has unread posts
yessiree
yessiree he
Mafia Scum
yessiree he
Mafia Scum Mafia Scum
Posts: 4389 Joined: June 6, 2013
Pronoun: he
Post
Post #143 (ISO ) » Thu May 17, 2018 9:12 am
Post
by yessiree » Thu May 17, 2018 9:12 am
maybe you fixed it locally and forgot to push?
Psyche
Psyche he/they
Survivor
Psyche he/they
Survivor Survivor
Posts: 10762 Joined: April 28, 2011
Pronoun: he/they
Post
Post #144 (ISO ) » Thu May 17, 2018 9:15 am
Post
by Psyche » Thu May 17, 2018 9:15 am
yeah probably
Psyche
Psyche he/they
Survivor
Psyche he/they
Survivor Survivor
Posts: 10762 Joined: April 28, 2011
Pronoun: he/they
Post
Post #145 (ISO ) » Thu May 17, 2018 9:16 am
Post
by Psyche » Thu May 17, 2018 9:16 am
let's use the issues feature on github to track these problems
Psyche
Psyche he/they
Survivor
Psyche he/they
Survivor Survivor
Posts: 10762 Joined: April 28, 2011
Pronoun: he/they
Post
Post #146 (ISO ) » Thu May 17, 2018 9:38 am
Post
by Psyche » Thu May 17, 2018 9:38 am
Ill go through every post in the thread and make sure all issues/proposals are either resolved or have an associated issue in the repo
yessiree
yessiree he
Mafia Scum
yessiree he
Mafia Scum Mafia Scum
Posts: 4389 Joined: June 6, 2013
Pronoun: he
Post
Post #147 (ISO ) » Thu May 17, 2018 10:49 am
Post
by yessiree » Thu May 17, 2018 10:49 am
i need a thread (to spam) to test makePosts, it seems to have the same issue sendPM had before I added gevent
maybe i will make requests in makePosts async too hmmmm
Psyche
Psyche he/they
Survivor
Psyche he/they
Survivor Survivor
Posts: 10762 Joined: April 28, 2011
Pronoun: he/they
Post
Post #148 (ISO ) » Fri May 18, 2018 9:29 am
Post
by Psyche » Fri May 18, 2018 9:29 am
I'm free. This weekend I will test and cleanup old code and implement a first version of the votecount pagetopper.
yessiree
yessiree he
Mafia Scum
yessiree he
Mafia Scum Mafia Scum
Posts: 4389 Joined: June 6, 2013
Pronoun: he
Post
Post #149 (ISO ) » Fri May 18, 2018 9:55 am
Post
by yessiree » Fri May 18, 2018 9:55 am
I decided to split my changes into 3 separate PRs so it's easier to merge them individually.
one for the pagetopper prototype; one for fixing makePosts; and one for fixing getNumberOfPosts (optional if you're gonna push your fix)
Copyright © MafiaScum. All rights reserved.