I've been massively overcomplicating it and the break for personal stuff has made me realise that so gonna simplify and then complete this and then have a personal pizza party
"Am I a ghost like you, caught between the seams of two intertwining melodies?"
am sure to drift in and out but would like to fit in some time to start contributing and helping keep momentum. would also help me build my comfort w/ typescript and get ideas for my other projects.
first step is probably checking if i can set up the dev environment by following your instructions
in the meantime do you think there are any "good first issues" you could add to the repo that could get my feet wet w/o disrupting your other plans?
In post 102, Psyche wrote:
am sure to drift in and out but would like to fit in some time to start contributing and helping keep momentum. would also help me build my comfort w/ typescript and get ideas for my other projects.
first step is probably checking if i can set up the dev environment by following your instructions
in the meantime do you think there are any "good first issues" you could add to the repo that could get my feet wet w/o disrupting your other plans?
Yeah so I just remembered I left the repo in a state that's broken in the sense that as soon as the bg script idles, the page needs to refreshed and thats not a super long time either so just beware of that. I should get that fixed pretty soon (today or tomorrow).
In terms of good first issues, I'll get back to that I just need time to look back over the project
"Am I a ghost like you, caught between the seams of two intertwining melodies?"
been wanting to contribute to this project too, i'll revisit this soon!
quick question @JV, why did you decide to use a package like zod, as opposed to just regular TSDoc? zod is kind of intimidating to see in a ts project ngl
In post 104, yessiree wrote:
been wanting to contribute to this project too, i'll revisit this soon!
quick question @JV, why did you decide to use a package like zod, as opposed to just regular TSDoc? zod is kind of intimidating to see in a ts project ngl
I used what I was most comfortable with as I wanted to spit something out pretty fast, I haven’t touched much tsdoc all things considered even though I probably should.
"Am I a ghost like you, caught between the seams of two intertwining melodies?"
In post 104, yessiree wrote:
been wanting to contribute to this project too, i'll revisit this soon!
quick question @JV, why did you decide to use a package like zod, as opposed to just regular TSDoc? zod is kind of intimidating to see in a ts project ngl
I used what I was most comfortable with as I wanted to spit something out pretty fast, I haven’t touched much tsdoc all things considered even though I probably should.
gotcha, i was just wondering why u would use zod because it is kinda overkill for this project, interfaces and TSDoc that come out of the box with typescript should be good enough
maybe my first PR will be deprecating zod and replacing it with typescript native syntax
I fixed my computer once again so with people wanting to contribute I should probably fix the glaring issue which is the timeout problem, I overcomplicated it to all hell and I really shouldn't have.
"Am I a ghost like you, caught between the seams of two intertwining melodies?"
Alright so I realised that I've overcomplicated this project to an extreme degree, I've reverted back to an older version and I am going to focus on simplifying what the current process is cuz my god my eyes hurt looking at this code
"Am I a ghost like you, caught between the seams of two intertwining melodies?"
And for the record, I have very little experience working with other people on a codebase. I got no idea how to use github beyond the very surface level stuff, I reverted to an older commit so if that fucks anything over regarding your forks uh, sorry?
I did make a branch prior to doing so, so that I can copy/paste anything to do with the UI changes that I've made after moving to a tRPC thing like a chump
"Am I a ghost like you, caught between the seams of two intertwining melodies?"
In post 104, yessiree wrote:
quick question @JV, why did you decide to use a package like zod, as opposed to just regular TSDoc? zod is kind of intimidating to see in a ts project ngl
Can TSDoc validate objects? Because I'm mostly using Zod to validate types so I don't have to go through and check them myself, as there is no typesafe layer when communicating from the content scripts and the bg scripts
"Am I a ghost like you, caught between the seams of two intertwining melodies?"
In post 104, yessiree wrote:
quick question @JV, why did you decide to use a package like zod, as opposed to just regular TSDoc? zod is kind of intimidating to see in a ts project ngl
Can TSDoc validate objects? Because I'm mostly using Zod to validate types so I don't have to go through and check them myself, as there is no typesafe layer when communicating from the content scripts and the bg scripts
if you are validating objects during runtime (from user input), there is no easy way, because types don't exist in runtime, you'd have to go through the good ol' user input validation step
In post 104, yessiree wrote:
quick question @JV, why did you decide to use a package like zod, as opposed to just regular TSDoc? zod is kind of intimidating to see in a ts project ngl
Can TSDoc validate objects? Because I'm mostly using Zod to validate types so I don't have to go through and check them myself, as there is no typesafe layer when communicating from the content scripts and the bg scripts
if you are validating objects during runtime (from user input), there is no easy way, because types don't exist in runtime, you'd have to go through the good ol' user input validation step
In post 104, yessiree wrote:
quick question @JV, why did you decide to use a package like zod, as opposed to just regular TSDoc? zod is kind of intimidating to see in a ts project ngl
Can TSDoc validate objects? Because I'm mostly using Zod to validate types so I don't have to go through and check them myself, as there is no typesafe layer when communicating from the content scripts and the bg scripts
if you are validating objects during runtime (from user input), there is no easy way, because types don't exist in runtime, you'd have to go through the good ol' user input validation step
In post 104, yessiree wrote:
quick question @JV, why did you decide to use a package like zod, as opposed to just regular TSDoc? zod is kind of intimidating to see in a ts project ngl
Can TSDoc validate objects? Because I'm mostly using Zod to validate types so I don't have to go through and check them myself, as there is no typesafe layer when communicating from the content scripts and the bg scripts
if you are validating objects during runtime (from user input), there is no easy way, because types don't exist in runtime, you'd have to go through the good ol' user input validation step
This thing still hates me no matter what I do. Can't even get it working with just the player list again. I recall last time I used it I had to workaround the dead section not working by just removing those players from the list.
"Yeah after a point it felt like Aureal was the only one talking sense despite being a goose so I just followed."
-furtiveglance
In post 118, Aureal wrote:
This thing still hates me no matter what I do. Can't even get it working with just the player list again. I recall last time I used it I had to workaround the dead section not working by just removing those players from the list.
I recall last time the issue was using tabs and not spaces or something (which is so silly of a problem) is it that again?
"Am I a ghost like you, caught between the seams of two intertwining melodies?"
Nope, definitely using spaces. Repeatedly tried copy/pasting the both the last game's file and the formatting you gave me and just adjusting the names.
"Yeah after a point it felt like Aureal was the only one talking sense despite being a goose so I just followed."
-furtiveglance
In post 118, Aureal wrote:
This thing still hates me no matter what I do. Can't even get it working with just the player list again. I recall last time I used it I had to workaround the dead section not working by just removing those players from the list.
I recall last time the issue was using tabs and not spaces or something (which is so silly of a problem) is it that again?
In post 120, Aureal wrote:
Nope, definitely using spaces. Repeatedly tried copy/pasting the both the last game's file and the formatting you gave me and just adjusting the names.
In post 118, Aureal wrote:
This thing still hates me no matter what I do. Can't even get it working with just the player list again. I recall last time I used it I had to workaround the dead section not working by just removing those players from the list.
I recall last time the issue was using tabs and not spaces or something (which is so silly of a problem) is it that again?
In post 120, Aureal wrote:
Nope, definitely using spaces. Repeatedly tried copy/pasting the both the last game's file and the formatting you gave me and just adjusting the names.
one of them is using "view=print" mode when scraping posts, which should drastically speed up votecount generation since it potentially reduces the response payload size by over 90%! (from over 1 MB to ~40 kB per request)
well that's good at least
well that's good at least